-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-2599 Update PC to support hierarchical consent notices + Update all types #5291
Open
lucanovera
wants to merge
27
commits into
main
Choose a base branch
from
PROD-2599-Privacy-Center-Update-consent-management-screen-to-render-hierarchical-notices
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PROD-2599 Update PC to support hierarchical consent notices + Update all types #5291
lucanovera
wants to merge
27
commits into
main
from
PROD-2599-Privacy-Center-Update-consent-management-screen-to-render-hierarchical-notices
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
…-Center-Update-consent-management-screen-to-render-hierarchical-notices
lucanovera
changed the title
PROD-2599 privacy center update consent management screen to render hierarchical notices
PROD-2599 Update PC to support hierarchical consent notices + Update all types
Sep 17, 2024
fides Run #9973
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5291/merge
|
Run status |
Passed #9973
|
Run duration | 00m 36s |
Commit |
3a39c33d35 ℹ️: Merge b44643d5920ceeef54c57fa77246c36ef65db8af into 31bc63a2a299544cb8f76e552320...
|
Committer | Lucano Vera |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Implement hierarchical relationships for Privacy Center consent. Update all openapi generated types, fix type issues.
BE branch needed: https://github.com/ethyca/fidesplus/pull/1602
FE admin-ui branch: #5264
Note for reviewer: You'll probably want to ignore the autogenerated types changes that are in the types/models folder. Also you'll see some type fixes, casting, adding ? !. Basically PC was using a set of hardcoded minimal types that were very outdated AND it still supports a "config-file" driven consent that doesn't use the api. The goal was to get everything updated and typescript working, but it will definitely look cleaner once we deprecate the config consent mode.
Code Changes
Screenshots
Steps to Confirm
Admin UI pre-requesites
Privacy Center
Pre-Merge Checklist
CHANGELOG.md