-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Accept/Reject All with minimal TCF #5298
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides Run #10003
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5298/merge
|
Run status |
Passed #10003
|
Run duration | 00m 39s |
Commit |
342d3ef672 ℹ️: Merge 7dc504fba4725286b886b294b35a3f2285056459 into 59978cb33e2d6ba234914936f237...
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
This is working, I see the spinner. We don't want to draw attention to the Manage Preferences button though since we want them opting in. I suggest we only show the spinner if the button is clicked before layer two is loaded.
I was never able to see a spinner on all three?
The spinner was not showing but I could see the network calls had not completed when I clicked accept all, the banner closed, and the ticket was created! |
Are you using the backend with Dawn's latest changes or not yet? |
7c80930
to
0bb4d83
Compare
I am! |
Cool. Then you shouldn't see all 3 spinners. That was for backwards compatibility :) |
8d7a6cb
to
d8d48bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
fides Run #10007
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #10007
|
Run duration | 00m 38s |
Commit |
a19d30ba57: Support Accept/Reject All with minimal TCF (#5298)
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Closes PROD-2777
Description Of Changes
Today, the “minimal” TCF banner can display the banner but the “Accept All” and “Reject All” actions are not enabled until the “full” experience is loaded. This can take several seconds to do on a low-speed connection, which creates a window where users can see a banner but are unable to opt-in.
These changes are set up for handling a new scenario in which a minimal version of
experience.gvl
is provided as part of the minimal TCF experience response.If no GVL is included, we'll at least show some spinners during the loading of the full experience to not appear "broken" during that time.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md