Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken fuzzy search tests #5301

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix broken fuzzy search tests #5301

wants to merge 2 commits into from

Conversation

eastandwestwind
Copy link
Contributor

Closes Unticketed

Description Of Changes

Address pre-existing test failures with fuzzy search

Code Changes

  • Fix tests

Steps to Confirm

  • Run nox -s dev -- shell then pytest tests/ops/api/v1/endpoints/test_privacy_request_endpoints.py::TestGetPrivacyRequests
  • Confirm tests pass

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 6:22pm

@cypress Cypress
Copy link

cypress bot commented Sep 19, 2024 •
edited
Loading

fides    Run #9993

Run Properties:  status check passed Passed #9993  •  git commit af04930fe4 ℹ️: Merge cd0421e0d57e67bcdb98afaee2a01ccdcb1f4538 into cf742714ca6a8520fe625360c801...
Project fides
Branch Review refs/pull/5301/merge
Run status status check passed Passed #9993
Run duration 00m 38s
Commit git commit af04930fe4 ℹ️: Merge cd0421e0d57e67bcdb98afaee2a01ccdcb1f4538 into cf742714ca6a8520fe625360c801...
Committer Catherine Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@erosselli erosselli mentioned this pull request Sep 23, 2024
Merged
11 tasks
@pattisdr
Copy link
Contributor

@eastandwestwind just double checking the intent here - we also have failing tests around the DynamoDB and Snowflake, in the External-Datastores workflow, you have to add the run-unsafe-ci-checks label to see the failures here. Is that covered here or should it be retickted separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eastandwestwind @pattisdr