Fix cached translation issues with Minimal TCF experience #5306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user's locale includes configured as override anyway
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
gilluminate
force-pushed
the
PROD-2764-mediavine-fides-js-client-code
branch
from
7ea867f
to
a525282
Compare
gilluminate
commented
Sep 20, 2024
Comment on lines
78
to
82
| useEffect(() => { | ||
| if (!currentLocale && i18n.locale) { | ||
| setCurrentLocale(i18n.locale); | ||
| } | ||
| }, [currentLocale, i18n.locale, setCurrentLocale]); |
There was a problem hiding this comment.
i18n-context was updated which made this unnecessary
gilluminate
commented
Sep 20, 2024
Comment on lines
73
to
79
| useEffect(() => { | ||
| if (!currentLocale) { | ||
| // initialize the i18n locale using the minimal experience | ||
| setCurrentLocale(minExperienceLocale); | ||
| } | ||
| }, [currentLocale, minExperienceLocale, setCurrentLocale]); | ||
|
|
There was a problem hiding this comment.
i18n-context was updated which made this unnecessary
gilluminate
commented
Sep 20, 2024
Comment on lines
-103
to
-106
| // We need to track if the experience and GVL translations are loading separately | ||
| // because they are loaded asynchronously and we need to know when both are done | ||
| // in order to set the i18n loading state. | ||
| let isExperienceLoading = false; |
There was a problem hiding this comment.
This was causing the globe to spin unnecessarily while GVL translations loaded in the background. GVL is only needed for Modal, so this is overkill on the banner.
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5306/merge
|
| Run status |
|
| Run duration | 00m 37s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
gilluminate
commented
Sep 20, 2024
Comment on lines
34
to
41
| const onSetCurrentLocale = useCallback( | ||
| (locale: string) => { | ||
| i18nInstance.activate(locale); | ||
| setCurrentLocale(locale); | ||
| }, | ||
| [i18nInstance, setCurrentLocale], | ||
| ); | ||
|
|
There was a problem hiding this comment.
This was all overkill and was causing some problems. Just use the ol' i18n.locale and i18n.activate as intended
gilluminate
force-pushed
the
PROD-2764-mediavine-fides-js-client-code
branch
from
15de4d5
to
78060f3
Compare
lucanovera
approved these changes
Sep 20, 2024
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 37s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Vagoasdf
pushed a commit
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2764
Description Of Changes
When the fides.js script gets cached, but a user changes their browser's language, we get into a weird state with multiple languages (especially after the GVL languages load correctly).
Code Changes
Accept_Languagein theVaryto instruct caches to reset when language changeswindow.fides_overrides.fides_locale) and load the available translation until full TCF Experience is ready with the correct language.Steps to Confirm
fides-js-demo.html:Replace:
With:
windowsetting, it will first load the English banner and the language picker's globe icon should immediately start spinning to indicate a language is loading. Once the full experience loads, it should replace English with the configured language of French. This is just an edge case we need to handle gracefully.Pre-Merge Checklist
CHANGELOG.md