Updating custom integrations to support multiple identities #5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
galvana
added
the
run unsafe ci checks
galvana
commented
Sep 23, 2024
| identities = list({k for k, v in identity_data.items() if v}) | ||
| if len(identities) > 1: | ||
| raise FidesopsException( | ||
| "Only one identity can be specified for SaaS connector traversal" |
There was a problem hiding this comment.
This is the error we're currently seeing, but this isn't accurate since we support multiple identities now
| assert len( | ||
| access_results[f"{fides_key}:{collection['name']}"] | ||
| ), f"No rows returned for collection '{collection['name']}'" | ||
| if not skip_access_results_check: |
There was a problem hiding this comment.
Quick fix to avoid checking for access data. This is necessary since our test account for Responsys isn't going to return access data for every collection.
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5318/merge
|
| Run status |
|
| Run duration | 00m 42s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Vagoasdf
approved these changes
Sep 24, 2024
| "Unsupported identity type for Oracle Responsys connector. Currently only `email` and `phone_number` are supported" | ||
| ) | ||
| for identity in get_identities(privacy_request): | ||
| if identity == "email": |
There was a problem hiding this comment.
We could extract the code fragment for retrieving the query_ids and query_attributes into its own method for readability, now that we are one level deeper with a for loop. It would help readability
…pport-multiple-identities
galvana
deleted the
PROD-2794-update-responsys-integration-to-support-multiple-identities
branch
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2794
Description Of Changes
Updating the Responsys and Firebase Auth integrations to support multiple identities. These two integrations are custom and were relying on some code that is no longer in use.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md