Attentive fix #5319
Merged
Attentive fix #5319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5319/merge
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Bruno Gutierrez Rios |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
galvana
requested changes
Sep 25, 2024
Vagoasdf
force-pushed
the
AttentiveFix
branch
from
9ed7770
to
dc90025
Compare
|
Looks like something happened with git and it decided to include everything on the main branch that was changed on the previous weeks. Rebased and cleaned it up, it should be ok now |
Vagoasdf
force-pushed
the
AttentiveFix
branch
from
dc90025
to
4a7fe14
Compare
galvana
approved these changes
Sep 28, 2024
galvana
requested changes
Sep 28, 2024
galvana
approved these changes
Sep 30, 2024
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 40s |
| Commit |
|
| Committer | Bruno Gutierrez Rios |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
adamsachs
pushed a commit
that referenced
this pull request
Oct 1, 2024
Co-authored-by: Adrian Galvan <[email protected]>
Kelsey-Ethyca
pushed a commit
that referenced
this pull request
Oct 3, 2024
Co-authored-by: Adrian Galvan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Currently we have the Attentive email integration as a high level connection type category, and that was causing conflict with lower level connection types, such as the new SaaS Attentive configuration. Since we are transitioning into using SaaS we've updated the reference to attentive_email, in order to avoid name collisions
Ideally, the Attentive Email integration should be a generic email integration. That should be the next step on the transition
Note: We Should check our strategy of communication with our clients before updating this, to avoid any breakage
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works