-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple datasets on system integrations #5327
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ople/2808-2678-integration
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides Run #10156
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5327/merge
|
Run status |
Passed #10156
|
Run duration | 00m 39s |
Commit |
67d580030e ℹ️: Merge 9cd2434b634f2093abff471f27f5b8e1a7fcb0ee into 7cd8f46d9a5f12055346a09f35ac...
|
Committer | jpople |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
gilluminate
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! I was able to test locally and was able to select multiple values.
fides Run #10157
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #10157
|
Run duration | 00m 38s |
Commit |
077d26642d: Allow multiple datasets on system integrations (#5327)
|
Committer | jpople |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
adamsachs
pushed a commit
that referenced
this pull request
Oct 1, 2024
Co-authored-by: Adrian Galvan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2678
Description Of Changes
Changes dataset select in system form to allow multiple datasets to be selected.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md