Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple datasets on system integrations #5327

Merged
merged 12 commits into from
Sep 25, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Sep 25, 2024

Closes PROD-2678

Description Of Changes

Changes dataset select in system form to allow multiple datasets to be selected.

Screenshot 2024-09-25 at 00 05 47

Code Changes

  • Replace old dataset config field in connector parameters form with standard CustomSelect
  • Refactor dataset config field to allow multiple datasets to be selected
  • Change connector parameters form to use new PUT /datasetconfig endpoint instead of PATCH endpoint (this is necessary to allow configs to be removed)

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 4:47pm

Copy link

cypress bot commented Sep 25, 2024

fides    Run #10156

Run Properties:  status check passed Passed #10156  •  git commit 67d580030e ℹ️: Merge 9cd2434b634f2093abff471f27f5b8e1a7fcb0ee into 7cd8f46d9a5f12055346a09f35ac...
Project fides
Branch Review refs/pull/5327/merge
Run status status check passed Passed #10156
Run duration 00m 39s
Commit git commit 67d580030e ℹ️: Merge 9cd2434b634f2093abff471f27f5b8e1a7fcb0ee into 7cd8f46d9a5f12055346a09f35ac...
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! I was able to test locally and was able to select multiple values.

@jpople jpople merged commit 077d266 into main Sep 25, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-2678/multiple-dataset-integrations branch September 25, 2024 17:01
Copy link

cypress bot commented Sep 25, 2024

fides    Run #10157

Run Properties:  status check passed Passed #10157  •  git commit 077d26642d: Allow multiple datasets on system integrations (#5327)
Project fides
Branch Review main
Run status status check passed Passed #10157
Run duration 00m 38s
Commit git commit 077d26642d: Allow multiple datasets on system integrations (#5327)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

adamsachs pushed a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants