Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DynamoDB tests #5348

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix DynamoDB tests #5348

merged 1 commit into from
Oct 3, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Oct 3, 2024 •
edited
Loading

Description Of Changes

Added auth_method to DynamoDB fixtures.

Code Changes

  • Added auth_method to DynamoDB fixtures.

Steps to Confirm

  • Run DynamoDB tests.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@andres-torres-marroquin andres-torres-marroquin added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Oct 3, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 4:33pm

@cypress Cypress
Copy link

cypress bot commented Oct 3, 2024

fides    Run #10279

Run Properties:  status check passed Passed #10279  •  git commit 8cce1cdbfd ℹ️: Merge 71dd8668755c3259b74ad45e09c45bb057ef1b6d into 0ea77a67b73cc3be1c25433b690f...
Project fides
Branch Review refs/pull/5348/merge
Run status status check passed Passed #10279
Run duration 00m 39s
Commit git commit 8cce1cdbfd ℹ️: Merge 71dd8668755c3259b74ad45e09c45bb057ef1b6d into 0ea77a67b73cc3be1c25433b690f...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@andres-torres-marroquin andres-torres-marroquin marked this pull request as ready for review October 3, 2024 17:50
@andres-torres-marroquin andres-torres-marroquin merged commit fa8e996 into main Oct 3, 2024
34 of 40 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the fix-dynamodb-tests branch October 3, 2024 18:08
@cypress Cypress
Copy link

cypress bot commented Oct 3, 2024

fides    Run #10288

Run Properties:  status check passed Passed #10288  •  git commit fa8e99605c: Fix DynamoDB tests (#5348)
Project fides
Branch Review main
Run status status check passed Passed #10288
Run duration 00m 37s
Commit git commit fa8e99605c: Fix DynamoDB tests (#5348)
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erosselli erosselli erosselli approved these changes

Assignees
No one assigned
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andres-torres-marroquin @erosselli