Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stale items rendering on D&D tables #5372

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Fix stale items rendering on D&D tables #5372

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4735968
fix D&D table row keys
jpople Oct 14, 2024
505bf98
update changelog
jpople Oct 14, 2024
7a0054a
update key generation
jpople Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/admin-ui/src/features/data-discovery-and-detection/utils/getResourceRowName.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { StagedResource } from "~/types/api";

const getResourceRowName = (row: StagedResource) =>
`${row.monitor_config_id}-${row.name ?? row.urn}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think urn already includes the monitor id, so we don't need it?

`${row.monitor_config_id}-${row.urn}`;

export default getResourceRowName;
Loading