Add Docker Hub auth to rate-limited CI workflows #5373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
RobertKeyser
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
I did notice in other workflows, we define them as environment variables with the following pattern under the env key
DOCKER_USER: ethycaci
DOCKER_RO_TOKEN: ${{ secrets.DOCKER_RO_TOKEN }}
And then use those envs instead of the secrets directly.
I think this should work, but if it doesn't, we'll go that route. Either way, approved.
fides
|
||||||||||||||||||||||||||
| Project |
fides
|
| Run status |
|
| Run duration | 00m 40s |
| Commit |
|
| Committer | Dave Quinlan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
daveqnet
added
the
do not merge
|
Adding Do Not Merge label. The Backend Code Checks workflow needs to be rethought as the actions step logs into Docker Hub... and then logs out before the next job where auth is needed 🥹 |
RobertKeyser
approved these changes
Oct 14, 2024
|
Thanks Rob! Assuming CI passes, I'll merge this in the morning. |
daveqnet
removed
the
do not merge
fides
|
||||||||||||||||||||||||||
| Project |
fides
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | Dave Quinlan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OPS-772
Description Of Changes
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works