Fix button visual issues #5386
Merged
Fix button visual issues #5386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jpople
commented
Oct 16, 2024
| @@ -28,7 +28,6 @@ const NewDataset: NextPage = () => { | |||
| <Box> | |||
| <Button | |||
| onClick={() => setGenerateMethod("yaml")} | |||
| ghost={generateMethod === "yaml"} | |||
There was a problem hiding this comment.
Prior to migrating, the button was in an "active"/pressed state while the YAML form was open on the page. Ant doesn't allow you to set the pressed state in props, but I'm not sure it's really necessary here anyway.
fides
|
||||||||||||||||||||||||||
| Project |
fides
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | jpople |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
gilluminate
approved these changes
Oct 16, 2024
Comment on lines
+39
to
+41
| <Button onClick={onClear} className="bg-[#f5f5f5] hover:!bg-[#d9d9d9]"> | ||
| Clear | ||
| </Button> |
There was a problem hiding this comment.
Is this going to be common for search inputs? Can this component be reused outside of d&d? Maybe move this to a more common directory for sharing across the board if that's the case.
|
Overall looks good. Approved with one suggestion for future consideration. |
fides
|
||||||||||||||||||||||||||
| Project |
fides
|
| Run status |
|
| Run duration | 00m 37s |
| Commit |
|
| Committer | jpople |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
14 tasks
Kelsey-Ethyca
pushed a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HJ-60
Description Of Changes
Fixes several visual issues introduced by Ant button migration.
Changes "default" button color from light gray to white:
Changes spacing between action buttons on privacy request manager page:
Adds space between buttons on integration detail view:
Fixes a bug where "upload a dataset YAML" button in add dataset view was in "ghost" state:
Tweaks colors on search input and clear button to differentiate more clearly:
Pre-Merge Checklist
CHANGELOG.md