Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search input width on D&D tables #5390

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fix search input width on D&D tables #5390

merged 2 commits into from
Oct 17, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Oct 16, 2024

Closes HJ-35

Description Of Changes

Restores width of search input to stop the icon legend tooltip from floating awkwardly off to the side.

Screenshot 2024-10-16 at 14 30 43
Screenshot 2024-10-16 at 14 31 01

Pre-Merge Checklist

  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 7:36pm

@cypress Cypress
Copy link

cypress bot commented Oct 16, 2024

fides    Run #10481

Run Properties:  status check passed Passed #10481  •  git commit 7d3d9b626c ℹ️: Merge 611c9a0c9f8820e95723fbc344394dc1b402667b into 221c98585d5f500066b1d503c07c...
Project fides
Run status status check passed Passed #10481
Run duration 00m 38s
Commit git commit 7d3d9b626c ℹ️: Merge 611c9a0c9f8820e95723fbc344394dc1b402667b into 221c98585d5f500066b1d503c07c...
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

@jpople jpople merged commit 5aa17ad into main Oct 17, 2024
13 checks passed
@jpople jpople deleted the jpople/hj-35/dnd-tooltip-fix branch October 17, 2024 14:29
@cypress Cypress
Copy link

cypress bot commented Oct 17, 2024

fides    Run #10504

Run Properties:  status check passed Passed #10504  •  git commit 5aa17ad13f: Fix search input width on D&D tables (#5390)
Project fides
Run status status check passed Passed #10504
Run duration 00m 38s
Commit git commit 5aa17ad13f: Fix search input width on D&D tables (#5390)
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpople @gilluminate