Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROD-1410: Pass property id when fides.js intializes #5393

Merged
merged 2 commits into from
Oct 17, 2024
Merged

PROD-1410: Pass property id when fides.js intializes #5393

merged 2 commits into from
Oct 17, 2024

Conversation

tvandort
Copy link
Contributor

@tvandort tvandort commented Oct 16, 2024 •
edited
Loading

Closes [PROD-1410]

Description Of Changes

If you call Fides.init() it doesn't seem to pass property ids specified in the config. This PR should fix that.

Code Changes

  • Passed property id to initialization function.

Steps to Confirm

  • Not sure

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 1:43pm

@cypress Cypress
Copy link

cypress bot commented Oct 16, 2024 •
edited
Loading

fides    Run #10501

Run Properties:  status check passed Passed #10501  •  git commit 032f3675b9 ℹ️: Merge a4546083a69bde0dff5456b9ea3804c4030a73b9 into 60f69d6c12c41cdab612c5d03e96...
Project fides
Run status status check passed Passed #10501
Run duration 00m 39s
Commit git commit 032f3675b9 ℹ️: Merge a4546083a69bde0dff5456b9ea3804c4030a73b9 into 60f69d6c12c41cdab612c5d03e96...
Committer Tom Van Dort
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

@tvandort tvandort force-pushed the prod-1410-initialize-fidesjs-with-property-id branch from f85b010 to 2f4de38 Compare October 16, 2024 22:34
@tvandort tvandort marked this pull request as ready for review October 16, 2024 22:34
@tvandort tvandort changed the title PROD-1410: Pass property id when fides.js intiializes PROD-1410: Pass property id when fides.js intializes Oct 16, 2024
gilluminate
gilluminate approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want to change the interface FetchExperienceOptions to not make this optional anymore;
From:
propertyId?: string | null;
To:
propertyId: string | null;

@tvandort
Copy link
Contributor Author

Thoughts on: propertyId: string | null | undefined or we'll have to start converting undefined to null in a bunch of places?

@gilluminate
Copy link
Contributor

Makes sense, totally fine! That's probably why it was marked optional to begin with. I like it being required but potentially undefined.

@tvandort
Update type definition.
a454608 
We want to force callers to think about passing property id in on all callsites but we do not want to have to convert it from null everywhere.
@tvandort tvandort merged commit 1551261 into main Oct 17, 2024
13 checks passed
@tvandort tvandort deleted the prod-1410-initialize-fidesjs-with-property-id branch October 17, 2024 14:19
@cypress Cypress
Copy link

cypress bot commented Oct 17, 2024

fides    Run #10503

Run Properties:  status check passed Passed #10503  •  git commit 1551261585: PROD-1410: Pass property id when fides.js intializes (#5393)
Project fides
Run status status check passed Passed #10503
Run duration 00m 38s
Commit git commit 1551261585: PROD-1410: Pass property id when fides.js intializes (#5393)
Committer Tom Van Dort
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvandort @gilluminate