Refactor search inputs #5398
Merged
Refactor search inputs #5398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides
|
||||||||||||||||||||||||||
| Project |
fides
|
| Run status |
|
| Run duration | 00m 36s |
| Commit |
|
| Committer | jpople |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
gilluminate
approved these changes
Oct 22, 2024
| extend: {}, | ||
| extend: { | ||
| colors: { | ||
| // TODO: unify with existing Tailwind "gray" color |
There was a problem hiding this comment.
Is there a ticket for this, by chance?
There was a problem hiding this comment.
I'm thinking this should be able to be done easily as part of the larger colors migration, but I can ticket it separately if you think that's a good idea.
There was a problem hiding this comment.
Is that what @Kelsey-Ethyca is working on? Just want to make sure it doesn't get lost in the shuffle.
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | jpople |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes unticketed
Description Of Changes
Styling tweaks to D&D search input "clear" button (particularly hover state). Before:
After:
Code Changes
Pre-Merge Checklist
CHANGELOG.md