-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: remove double line from final row's first column #5406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gilluminate
force-pushed
the
HJ-75-reporting-table-outline
branch
from
October 22, 2024 22:26
b080e2f
to
389f012
Compare
fides Run #10551
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5406/merge
|
Run status |
Passed #10551
|
Run duration | 00m 37s |
Commit |
9c89d4f28f ℹ️: Merge 389f01227046fae0a1ace0ef90bd0bf029a42cb5 into 07e8dd569694579cfaa90ddeacc8...
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
tvandort
approved these changes
Oct 22, 2024
fides Run #10553
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #10553
|
Run duration | 00m 37s |
Commit |
9b78de2377: Fix: remove double line from final row's first column (#5406)
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #HJ-75
Description Of Changes
On the bottom of the first column in the reporting view, there’s a double line. Let’s remove that. See ref image below.
Before:
After:
Steps to Confirm
http://localhost:3000/reporting/datamap
)Pre-Merge Checklist