Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove double line from final row's first column #5406

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Oct 22, 2024

Closes #HJ-75

Description Of Changes

On the bottom of the first column in the reporting view, there’s a double line. Let’s remove that. See ref image below.

Before:
with double border

After:
without double border

Steps to Confirm

  • Visit a populated Data map report page (eg. http://localhost:3000/reporting/datamap)
  • Scroll to the very bottom
  • First column should not have a double border

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:29pm

Copy link

cypress bot commented Oct 22, 2024

fides    Run #10551

Run Properties:  status check passed Passed #10551  •  git commit 9c89d4f28f ℹ️: Merge 389f01227046fae0a1ace0ef90bd0bf029a42cb5 into 07e8dd569694579cfaa90ddeacc8...
Project fides
Branch Review refs/pull/5406/merge
Run status status check passed Passed #10551
Run duration 00m 37s
Commit git commit 9c89d4f28f ℹ️: Merge 389f01227046fae0a1ace0ef90bd0bf029a42cb5 into 07e8dd569694579cfaa90ddeacc8...
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@gilluminate gilluminate merged commit 9b78de2 into main Oct 22, 2024
13 checks passed
@gilluminate gilluminate deleted the HJ-75-reporting-table-outline branch October 22, 2024 23:55
Copy link

cypress bot commented Oct 23, 2024

fides    Run #10553

Run Properties:  status check passed Passed #10553  •  git commit 9b78de2377: Fix: remove double line from final row's first column (#5406)
Project fides
Branch Review main
Run status status check passed Passed #10553
Run duration 00m 37s
Commit git commit 9b78de2377: Fix: remove double line from final row's first column (#5406)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants