HJ-103 - fix: Snowflake DSR integration fails with syntax error #5417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andres-torres-marroquin
added
the
run unsafe ci checks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5417/merge
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Andres Torres |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5417 +/- ##
==========================================
+ Coverage 83.84% 83.86% +0.01%
==========================================
Files 382 382
Lines 24073 24069 -4
Branches 2624 2624
==========================================
+ Hits 20185 20186 +1
+ Misses 3306 3300 -6
- Partials 582 583 +1 ☔ View full report in Codecov by Sentry. |
erosselli
approved these changes
Oct 24, 2024
thingscouldbeworse
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #HJ-103
Description Of Changes
Fixes Snowflake DSR integration fails with syntax error
Code Changes
SnowflakeQueryConfig.format_fields_for_querymethod.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works