Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding keepalive settings for Redshift #5433

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Oct 29, 2024

Closes LA-57

Description Of Changes

Adding keep-alive settings for the Redshift connector. Here is an explanation of the settings:

  • keepalives: enable tcp keepalive
  • keepalives_idle: seconds before sending first keepalive probe after the connection is idle
  • keepalives_interval: seconds between subsequent keepalive probes is no response is received
  • keepalives_count: number of failed keepalive probes before declaring a connection dead

Steps to Confirm

  • Will verify on customer's test/staging environment since we can't reproduce the (psycopg2.OperationalError) SSL SYSCALL error: EOF detected error locally

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 6:49pm

@galvana galvana requested a review from tvandort October 29, 2024 18:50
Copy link

cypress bot commented Oct 29, 2024

fides    Run #10664

Run Properties:  status check passed Passed #10664  •  git commit 3a4264aba7 ℹ️: Merge 2ef4f0956a1d0da475070a79800e97acc1badf8b into 4af14dc3215bbbad43c82234cd3a...
Project fides
Branch Review refs/pull/5433/merge
Run status status check passed Passed #10664
Run duration 00m 38s
Commit git commit 3a4264aba7 ℹ️: Merge 2ef4f0956a1d0da475070a79800e97acc1badf8b into 4af14dc3215bbbad43c82234cd3a...
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.87%. Comparing base (4af14dc) to head (2ef4f09).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fides/api/service/connectors/sql_connector.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5433      +/-   ##
==========================================
- Coverage   83.89%   83.87%   -0.02%     
==========================================
  Files         384      384              
  Lines       24112    24116       +4     
  Branches     2624     2624              
==========================================
  Hits        20228    20228              
- Misses       3302     3306       +4     
  Partials      582      582              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galvana galvana merged commit 6db9bbc into main Oct 29, 2024
37 of 39 checks passed
@galvana galvana deleted the LA-57-add-keepalive-settings-for-redshift branch October 29, 2024 19:32
Copy link

cypress bot commented Oct 29, 2024

fides    Run #10668

Run Properties:  status check passed Passed #10668  •  git commit 6db9bbc3fd: Adding keepalive settings for Redshift (#5433)
Project fides
Branch Review main
Run status status check passed Passed #10668
Run duration 00m 38s
Commit git commit 6db9bbc3fd: Adding keepalive settings for Redshift (#5433)
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants