Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update DSR integrations Ethyca logo #5436

Merged
merged 1 commit into from
Oct 30, 2024
Merged

update DSR integrations Ethyca logo #5436

merged 1 commit into from
Oct 30, 2024

Conversation

Kelsey-Ethyca
Copy link
Contributor

Closes # https://ethyca.atlassian.net/browse/LA-45

Code Changes

  • update DSR integrations Ethyca logo

Steps to Confirm

  • run admin ui
  • add a system
  • nav to integrations page
  • verify generic integrations have the new logo
Screenshot 2024-10-29 at 8 11 54 PM

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 3:22am

Linker44
Linker44 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@Linker44 Linker44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Locally and it works. 🚀

@cypress Cypress
Copy link

cypress bot commented Oct 30, 2024

fides    Run #10677

Run Properties:  status check passed Passed #10677  •  git commit 2badb43d85 ℹ️: Merge c52743897e838e7222120041d8ccbbcf60437f0a into 6db9bbc3fdc1e7bca2238dcf8240...
Project fides
Branch Review refs/pull/5436/merge
Run status status check passed Passed #10677
Run duration 00m 38s
Commit git commit 2badb43d85 ℹ️: Merge c52743897e838e7222120041d8ccbbcf60437f0a into 6db9bbc3fdc1e7bca2238dcf8240...
Committer Kelsey Thomas
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@Kelsey-Ethyca Kelsey-Ethyca merged commit 811a691 into main Oct 30, 2024
13 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the LA-45-update-generic-integration-logo branch October 30, 2024 22:19
@cypress Cypress
Copy link

cypress bot commented Oct 30, 2024

fides    Run #10698

Run Properties:  status check passed Passed #10698  •  git commit 811a691d32: update DSR integrations Ethyca logo (#5436)
Project fides
Branch Review main
Run status status check passed Passed #10698
Run duration 00m 37s
Commit git commit 811a691d32: update DSR integrations Ethyca logo (#5436)
Committer Kelsey Thomas
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linker44 Linker44 Linker44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kelsey-Ethyca @Linker44