Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAPI TypeScript types #5437

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Fix OpenAPI TypeScript types #5437

merged 5 commits into from
Oct 31, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Oct 30, 2024

Closes HJ-17

Code Changes

  • Brings OpenAPI types back up to date
  • Few small changes to resolve TypeScript errors

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 3:00pm

Copy link

cypress bot commented Oct 30, 2024

fides    Run #10689

Run Properties:  status check passed Passed #10689  •  git commit a88727a992 ℹ️: Merge 56cbbeed278c4edd220bf1d2d6da4d16d70d3f9d into eac2542b07b76ebc9a8a15386a1f...
Project fides
Branch Review refs/pull/5437/merge
Run status status check passed Passed #10689
Run duration 00m 37s
Commit git commit a88727a992 ℹ️: Merge 56cbbeed278c4edd220bf1d2d6da4d16d70d3f9d into eac2542b07b76ebc9a8a15386a1f...
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is mostly automated updates. Anything you think I should test or is this more of a "general regression test" kind of thing?

@jpople
Copy link
Contributor Author

jpople commented Oct 31, 2024

@gilluminate General regression, the only real manual change aside from adding some fallback []s was changing classifications (in the old classifier flow, not D&D) to rank based on score instead of aggregated_score which no longer exists.

@jpople jpople merged commit 008cf68 into main Oct 31, 2024
13 checks passed
@jpople jpople deleted the jpople/hj-17/fix-fe-types branch October 31, 2024 19:00
Copy link

cypress bot commented Oct 31, 2024

fides    Run #10720

Run Properties:  status check passed Passed #10720  •  git commit 008cf6818d: Fix OpenAPI TypeScript types (#5437)
Project fides
Branch Review main
Run status status check passed Passed #10720
Run duration 00m 40s
Commit git commit 008cf6818d: Fix OpenAPI TypeScript types (#5437)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants