Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor docs for make -> nox #547

Merged
merged 6 commits into from
May 6, 2022

Conversation

ThomasLaPiana
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana commented May 3, 2022

Closes #542

Code Changes

  • remove the Makefile
  • update the docs to remove all references to make and replace it with the appropriate nox command

Steps to Confirm

  • do a search for make and double check that every reference is just english

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Finalizes the work started in another PR to remove Make from the project

@ThomasLaPiana ThomasLaPiana changed the title Delete Makefile Refactor docs for make -> nox May 3, 2022
@ThomasLaPiana
Copy link
Contributor Author

@conceptualshark FYI a main difference here is that pip install nox or pip install -r dev-requirements.txt will replace any mention of installing make

most commands are the same, but instead formatted as nox -s cli as opposed to make cli

@conceptualshark conceptualshark marked this pull request as ready for review May 5, 2022 12:51
@conceptualshark conceptualshark requested review from a team May 5, 2022 12:51
.fides/fidesctl.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ThomasLaPiana ThomasLaPiana merged commit 95e0d07 into main May 6, 2022
@ThomasLaPiana ThomasLaPiana deleted the 542-overhaul-docs-to-replace-make-with-nox branch May 6, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhaul docs to replace make with nox
2 participants