Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync version of fastapi in setup.py with optional-requirement.txt #734

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Sync version of fastapi in setup.py with optional-requirement.txt #734

merged 2 commits into from
Jun 3, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Jun 3, 2022 •
edited
Loading

Closes #732

Code Changes

  • Bump version of FastAPI in setup.py to 0.77.1 to match optional-requirements.txt

Steps to Confirm

  • Run nox -s build_local
  • Run test suite

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

@sanders41 sanders41 requested a review from a team June 3, 2022 17:16
ThomasLaPiana
ThomasLaPiana approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing the change here and submitting the PR!

@sanders41 sanders41 merged commit 7dfc5d3 into main Jun 3, 2022
@sanders41 sanders41 deleted the sync-requirements branch June 3, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasLaPiana ThomasLaPiana ThomasLaPiana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FastAPI version in setup.py and optional-requirements.txt are different
2 participants
@sanders41 @ThomasLaPiana