Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate TestClient Usage #759

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Consolidate TestClient Usage #759

merged 3 commits into from
Jun 15, 2022

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Jun 14, 2022 •
edited
Loading

Closes #753

Code Changes

  • Consolidate usage of TestClient
  • Add removed test resolved by shared TestClient

Steps to Confirm

  • The properly scoped test_client fixture succeeds for all tests

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Split from #721, this cleans up usage of the test_client to be shared across test modules and resolves an issue where the loop was previously getting out of sync.

@SteveDMurphy SteveDMurphy self-assigned this Jun 14, 2022
@SteveDMurphy SteveDMurphy added the maintenance Refactoring or ongoing maintenance work label Jun 14, 2022
@SteveDMurphy SteveDMurphy added this to the 1.7.0 milestone Jun 14, 2022
@SteveDMurphy SteveDMurphy marked this pull request as ready for review June 14, 2022 18:42
@SteveDMurphy SteveDMurphy requested a review from a team June 14, 2022 18:42
ThomasLaPiana
ThomasLaPiana approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup task!

@SteveDMurphy SteveDMurphy merged commit 97138b7 into main Jun 15, 2022
@SteveDMurphy SteveDMurphy deleted the SteveDMurphy-753-api-testing-cleanup branch June 15, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasLaPiana ThomasLaPiana ThomasLaPiana approved these changes

Assignees

@SteveDMurphy SteveDMurphy

Labels
maintenance Refactoring or ongoing maintenance work
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

async testing of datamap endpoint
2 participants
@SteveDMurphy @ThomasLaPiana