Handling an invalidly generated fides_key #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the myriad of names allowed by different style databases, we need a method that allows some intervention without breaking. This is a start to handle invalid characters when generating a dataset. The function should be allowed to be repurposed when generating other types of resources as well. A further step would be to also validate if the fides_key already exists due and how we may want to handle that.
ThomasLaPiana
approved these changes
Jun 15, 2022
SteveDMurphy
added a commit
that referenced
this pull request
Jun 15, 2022
* validate the generated fides_key Due to the myriad of names allowed by different style databases, we need a method that allows some intervention without breaking. This is a start to handle invalid characters when generating a dataset. The function should be allowed to be repurposed when generating other types of resources as well. A further step would be to also validate if the fides_key already exists due and how we may want to handle that. * remove manual intervention and cli specific steps * testing * rename variable, fix docs from removed manual step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #749
Code Changes
fides_keyas part of generating a datasetfides_keyProvide an option to manually intervene with theremoved from this for further thought (i.e. option for API)fides_keyprovide a CLI option to accept all sanitized versions? (May be too early for this)yes, too early - see above for reasons pulledSteps to Confirm
check_fides_key("sample@"))Pre-Merge Checklist
CHANGELOG.mdDescription Of Changes
This bug was found while working with a design partner. Further steps may include looking at if the
fides_keyalready exists and providing an option to accept all suggested values.After chatting with the team, decided against providing a manual intervention option at this time. Two questions remain prior to merging:
generatecommand options (i.e.systems)1.6.1