Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete confirmation #809

Merged
merged 7 commits into from
Jun 29, 2022
Merged

Delete confirmation #809

merged 7 commits into from
Jun 29, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jun 27, 2022 •
edited
Loading

Closes #808

Code Changes

  • Adds a DeleteConfirmation component
  • Incorporates the component to add some friction to deleting

Steps to Confirm

  • Open up a dataset and delete either a field or a collection

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Screen.Recording.2022-06-27.at.3.33.48.PM.mov

@allisonking allisonking marked this pull request as ready for review June 27, 2022 19:59
ssangervasi
ssangervasi approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@ssangervasi ssangervasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple non-blocking suggetsions.

clients/admin-ui/src/features/dataset/EditCollectionDrawer.tsx Outdated Show resolved Hide resolved
clients/admin-ui/src/features/dataset/EditCollectionDrawer.tsx Outdated Show resolved Hide resolved
clients/admin-ui/src/features/common/DeleteConfirmation.tsx Outdated Show resolved Hide resolved
@allisonking allisonking merged commit 3f98490 into main Jun 29, 2022
@allisonking allisonking deleted the aking-808-delete-confirmation branch June 29, 2022 19:56
allisonking added a commit that referenced this pull request Jul 28, 2022
@allisonking
Delete confirmation (#809)
3b2c1fd 
* Fix styling

* Add DeleteConfirmation to deleting dataset fields and collections

* Update changelog

* Fix EditDatasetDrawer to take new props

* Address PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssangervasi ssangervasi ssangervasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add confirmation modal for deleting in dataset management UI
2 participants
@allisonking @ssangervasi