Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Okta support to generate endpoint #842

Merged
merged 4 commits into from
Jul 6, 2022
Merged

Conversation

earmenda
Copy link
Contributor

@earmenda earmenda commented Jul 5, 2022

Closes #810

Code Changes

  • Add okta-systems option to generate endpoint
  • Refactor okta generate code paths to be called from cli and api
  • Update usages of organization key to use common option organization_fides_key_option
  • Update generate integration tests to also call okta code path

Steps to Confirm

  • Automated tests

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

  • Straight forward change other than dealing with some async weirdness. Old code path used asyncio.run which cant be called from the api path.

@earmenda earmenda added this to the 1.8.0 milestone Jul 5, 2022
@earmenda earmenda requested a review from a team July 5, 2022 07:36
@earmenda earmenda self-assigned this Jul 5, 2022
Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @earmenda 👍🏽

If you think it makes sense to do, the only suggestion/nit I might have is that I get a little twisted with some of the function names in system.py (e.g. generate_system_okta, generate_okta_systems)

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits but otherwise LGTM!

@earmenda
Copy link
Contributor Author

earmenda commented Jul 6, 2022

Looks good to me @earmenda 👍🏽

If you think it makes sense to do,
the only suggestion/nit I might have is that I get a little twisted with some of the function names in system.py (e.g. generate_system_okta, generate_okta_systems)

@SteveDMurphy I agree it is a little bit odd but I'd say it is only because the system.py functions need to have the cli functions taken out. Right now the function generate_system_okta maps to the cli command generate system okta but it probably doesn't belong there. There is also a generate_okta_systems function which DOES belong here and does exactly what it says.

Co-authored-by: Thomas <[email protected]>
@earmenda earmenda merged commit 1d72cca into main Jul 6, 2022
@earmenda earmenda deleted the earmenda-okta-scanner-endpoint branch July 6, 2022 17:01
allisonking pushed a commit that referenced this pull request Jul 28, 2022
* Implement okta generate api

* Update changelog

* Update CHANGELOG.md

Co-authored-by: Thomas <[email protected]>

Co-authored-by: Eduardo Armendariz <[email protected]>
Co-authored-by: Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Okta support to generate endpoint
3 participants