-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Okta support to generate endpoint #842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @earmenda 👍🏽
If you think it makes sense to do, the only suggestion/nit I might have is that I get a little twisted with some of the function names in system.py
(e.g. generate_system_okta
, generate_okta_systems
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits but otherwise LGTM!
@SteveDMurphy I agree it is a little bit odd but I'd say it is only because the |
Co-authored-by: Thomas <[email protected]>
* Implement okta generate api * Update changelog * Update CHANGELOG.md Co-authored-by: Thomas <[email protected]> Co-authored-by: Eduardo Armendariz <[email protected]> Co-authored-by: Thomas <[email protected]>
Closes #810
Code Changes
organization_fides_key_option
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
asyncio.run
which cant be called from the api path.