Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typescript types for taxonomy is_default #997

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Update typescript types for taxonomy is_default #997

merged 2 commits into from
Aug 17, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Aug 17, 2022 •
edited
Loading

Closes #988

Code Changes

  • Regenerate openapi types
  • Add is_default field where relevant in taxonomy form

Steps to Confirm

  • Editing a taxonomy field should still work as expected

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Should just be a small types related change, so nothing noticeable. It looks like we haven't run the generate command in a bit though, so there are a few new models that are unrelated to taxonomy.

@allisonking allisonking marked this pull request as ready for review August 17, 2022 15:10
@allisonking allisonking requested review from a team, ssangervasi and LKCSmith August 17, 2022 15:10
LKCSmith
LKCSmith approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@LKCSmith LKCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

@allisonking allisonking merged commit 203e6cf into main Aug 17, 2022
@allisonking allisonking deleted the aking-988-frontend-taxonomy-is-default branch August 17, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKCSmith LKCSmith LKCSmith approved these changes

@ssangervasi ssangervasi Awaiting requested review from ssangervasi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frontend taxonomy UI needs to handle new is_default field
2 participants
@allisonking @LKCSmith