Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Commit

Permalink
[#557] MSSQL discovery script (#581)
Browse files Browse the repository at this point in the history
* adds script to discover mssql datastore compatibility

* make prints consistent

* updates changelog

* add URL template

* add warning

* store columns correctly

* move uncomitted secrets to another file to add to .gitignore

* remove empty secrets file, add to gitignore

* add comment explaining lack of secrets
  • Loading branch information
Sean Preston committed Jun 3, 2022
1 parent dd60b62 commit 71492f1
Show file tree
Hide file tree
Showing 3 changed files with 86 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -138,4 +138,7 @@ envfiles/
fides_uploads

# Prevent SaaS configs from being committed
saas_config.toml
saas_config.toml

# Script secrets
scripts/secrets.py
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ The types of changes are:
* Use the `RuleResponse` schema within the `PrivacyRequestReposnse` schema [#580](https://github.com/ethyca/fidesops/pull/580)
* Updated the webserver to use `PORT` config variable from the `fidesops.toml` file [#586](https://github.com/ethyca/fidesops/pull/586)

### Developer Experience
* Adds a script for MSSQL schema exploration [#557](https://github.com/ethyca/fidesops/pull/581)

## [1.5.1](https://github.com/ethyca/fidesops/compare/1.5.0...1.5.1) - 2022-05-27

### Added
Expand Down
79 changes: 79 additions & 0 deletions scripts/mssql_discover.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
import sqlalchemy

# This file is not committed to the repo, please create secrets.py with the required
# variables in the same dir as this file before running this script
from secrets import (
USER,
PASS,
IP,
PORT,
DB,
)

MASTER_MSSQL_URL = f"mssql+pyodbc://{USER}:{PASS}@{IP}:{PORT}/{DB}?driver=ODBC+Driver+17+for+SQL+Server"


SUPPORTED_DATA_TYPES = set(
[
# char types
"varchar",
"nvarchar",
"char",
"nchar",
"ntext",
"text",
# numeric types
"int",
"bigint",
"smallint",
"tinyint",
"money",
"float",
"decimal",
# date types
"date",
"datetime",
"datetime2",
"smalldatetime",
# other types
"bit",
]
)


def mssql_discover():
"""
Select all databases from the instance
Select the schema data for each data base
Check if there are any fields in the schema that Fidesops does not yet support
"""
engine = sqlalchemy.create_engine(MASTER_MSSQL_URL)
all_dbs = engine.execute("SELECT name FROM sys.databases;").all()
all_columns = []
flagged_columns = []
flagged_datatypes = set()
for db_name in all_dbs:
db_name = db_name[0]
try:
columns = engine.execute(
f"SELECT TABLE_NAME, COLUMN_NAME, DATA_TYPE FROM {db_name}.INFORMATION_SCHEMA.COLUMNS;"
).all()
except Exception:
continue

all_columns.extend(columns)
for table, column, data_type in columns:
if data_type not in SUPPORTED_DATA_TYPES:
flagged_datatypes.add(data_type)
flagged_columns.append(f"{db_name}.{table}.{column}: {data_type}")

print(f"{len(all_columns)} columns found")
print(f"{len(flagged_columns)} columns flagged")
print(f"Flagged datatypes:")
print(",\n".join(flagged_datatypes))
print(f"Flagged columns:")
print(",\n".join(flagged_columns))


if __name__ == "__main__":
mssql_discover()

0 comments on commit 71492f1

Please sign in to comment.