Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Incorrect docker build arg name #924

Closed
sanders41 opened this issue Jul 21, 2022 · 0 comments · Fixed by #925
Closed

Incorrect docker build arg name #924

sanders41 opened this issue Jul 21, 2022 · 0 comments · Fixed by #925
Labels
bug Something isn't working

Comments

@sanders41
Copy link
Contributor

sanders41 commented Jul 21, 2022 •
edited by mfbrown
Loading

Bug Description

In looking into #813 I noticed that the Makefile has a --build-arg with the name REQUIRE_MSSQL, but in the Dockerfile the build arg is named SKIP_MSSQL_INSTALLATION. This turned out not to be the cause of the failing CI tests, but should still be corrected.

Steps to Reproduce

  1. Do this...
  2. Then This...

Expected behavior

A description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

  • Version:
  • OS:
  • Python Version:
  • Docker Version:

Additional context

Add any other context about the problem here.
@sanders41 sanders41 added the bug Something isn't working label Jul 21, 2022
@sanders41 sanders41 mentioned this issue Jul 21, 2022
Merged
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct build arg variable name ethyca/fidesops
1 participant
@sanders41