Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Correct build arg variable name #925

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Correct build arg variable name #925

merged 2 commits into from
Jul 22, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Jul 21, 2022

Purpose

Correct the mssql build arg variable name in the Makefile

Changes

  • Change the build arg from REQUIRE_MSSQL="true" to SKIP_MSSQL_INSTALLATION="false"

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #924

@eastandwestwind eastandwestwind self-assigned this Jul 22, 2022
@eastandwestwind eastandwestwind merged commit 4a1d1ed into main Jul 22, 2022
@eastandwestwind eastandwestwind deleted the build-arg branch July 22, 2022 15:32
sanders41 added a commit that referenced this pull request Sep 22, 2022
* Correct build arg variable name

* Update CHANGELOG

Co-authored-by: Paul Sanders <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect docker build arg name
2 participants