Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Create AuditLog on privacy request approval #1038

Merged
merged 5 commits into from
Aug 5, 2022
Merged

Create AuditLog on privacy request approval #1038

merged 5 commits into from
Aug 5, 2022

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Aug 4, 2022 •
edited
Loading

Purpose

Add approval audit logs to it can be tracked when and who approved a privacy request.

Changes

  • Add approval audit logs to the backend

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1021

@TheAndrewJackson TheAndrewJackson changed the title 1021 create auditlog on privacy request approval Create AuditLog of privacy request approval Aug 4, 2022
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review August 4, 2022 18:43
@TheAndrewJackson TheAndrewJackson changed the title Create AuditLog of privacy request approval Create AuditLog on privacy request approval Aug 4, 2022
seanpreston
seanpreston suggested changes Aug 4, 2022
View reviewed changes
tests/ops/api/v1/endpoints/test_privacy_request_endpoints.py Outdated
user,
privacy_request,
):
privacy_request.status = PrivacyRequestStatus.pending
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the privacy_request_status_pending fixture for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I wasn't aware of that. Updated now

@seanpreston
Copy link
Contributor

Thanks @TheAndrewJackson — one minor change then good to ship

@seanpreston seanpreston self-assigned this Aug 4, 2022
@seanpreston seanpreston merged commit 374bead into main Aug 5, 2022
@seanpreston seanpreston deleted the 1021_create_auditlog_on_privacy_request_approval branch August 5, 2022 14:15
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
@TheAndrewJackson
Create AuditLog on privacy request approval (#1038)
9f8001e 
* Create approval audit logs

* Add tests

* disable a pylint lint

* Update changelog

* Update privacy_request fixture
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seanpreston seanpreston seanpreston approved these changes

Assignees

@seanpreston seanpreston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create AuditLog event on PrivacyRequest approval
2 participants
@TheAndrewJackson @seanpreston