Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Escape redis user and password #1104

Merged
merged 4 commits into from
Aug 18, 2022
Merged

Escape redis user and password #1104

merged 4 commits into from
Aug 18, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Aug 17, 2022

Purpose

Allow the redis password to contain special characters

Changes

  • Wrapped the redis user and password in quote_plus when generating the connection string in order to make them url friendly.

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #900

@sanders41 sanders41 changed the title Redis password Escape redis user and password Aug 17, 2022
@seanpreston seanpreston merged commit df98af5 into main Aug 18, 2022
@seanpreston seanpreston deleted the redis-password branch August 18, 2022 13:58
sanders41 added a commit that referenced this pull request Sep 22, 2022
* Escape redis user and password

* Update CHANGELOG

Co-authored-by: Paul Sanders <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration does not support Redis Passwords that Contain #
2 participants