Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

1009 id verification required endpoint #1221

Merged
merged 12 commits into from
Aug 30, 2022

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Aug 30, 2022

Purpose

Adds endpoint to determine whether subject identity is required. Also returns whether or not email service has been configured, which is required for subject identity verification.

Endpoint: GET {{host}}/id-verification/config/

Example response:

{
    "identity_verification_required": true,
    "valid_email_config_exists": false
}

Changes

  • Adds new endpoint for id verification config
  • Adds unit tests for endpoint
  • Updates postman collection

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1009

@@ -306,7 +306,7 @@ class ObjectField(Field):
fields: Dict[str, Field]

@validator("data_categories")
def validate_data_categories(
def validate_data_categories( # type: ignore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mypy check was giving the following error:

src/fidesops/ops/graph/config.py:309: error: The erased type of self
"fidesops.ops.graph.config.ObjectField" is not a supertype of its class
"Type[fidesops.ops.graph.config.ObjectField]"  [misc]
        def validate_data_categories(
        ^
Found 1 error in 1 file (checked [19](https://github.com/ethyca/fidesops/runs/8097316393?check_suite_focus=true#step:5:20)8 source files)

src/fidesops/ops/graph/config.py Outdated Show resolved Hide resolved
@eastandwestwind
Copy link
Contributor Author

Back over to you @sanders41 !

@sanders41 sanders41 merged commit b4e832b into main Aug 30, 2022
@sanders41 sanders41 deleted the 1009-id-verification-required-endpoint branch August 30, 2022 21:10
sanders41 added a commit that referenced this pull request Sep 22, 2022
* Adds identity verification config endpoint

* adds test, reuse existing config var, adds postman collection

* update changelog

* add type ignore

* move ignore line

* Update src/fidesops/ops/graph/config.py

Co-authored-by: Paul Sanders <[email protected]>

* remove duplicate lines in method

* another dupe line

* remove scope, update order of classmethod decorator

* remove dependencies on endpoint

* unused imports

Co-authored-by: Paul Sanders <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend - indicate if identify verification is required
2 participants