This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
1009 id verification required endpoint #1221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eastandwestwind
commented
Aug 30, 2022
src/fidesops/ops/graph/config.py
Outdated
@@ -306,7 +306,7 @@ class ObjectField(Field): | |||
fields: Dict[str, Field] | |||
|
|||
@validator("data_categories") | |||
def validate_data_categories( | |||
def validate_data_categories( # type: ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mypy check was giving the following error:
src/fidesops/ops/graph/config.py:309: error: The erased type of self
"fidesops.ops.graph.config.ObjectField" is not a supertype of its class
"Type[fidesops.ops.graph.config.ObjectField]" [misc]
def validate_data_categories(
^
Found 1 error in 1 file (checked [19](https://github.com/ethyca/fidesops/runs/8097316393?check_suite_focus=true#step:5:20)8 source files)
sanders41
reviewed
Aug 30, 2022
Co-authored-by: Paul Sanders <[email protected]>
sanders41
suggested changes
Aug 30, 2022
Back over to you @sanders41 ! |
sanders41
approved these changes
Aug 30, 2022
sanders41
added a commit
that referenced
this pull request
Sep 22, 2022
* Adds identity verification config endpoint * adds test, reuse existing config var, adds postman collection * update changelog * add type ignore * move ignore line * Update src/fidesops/ops/graph/config.py Co-authored-by: Paul Sanders <[email protected]> * remove duplicate lines in method * another dupe line * remove scope, update order of classmethod decorator * remove dependencies on endpoint * unused imports Co-authored-by: Paul Sanders <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds endpoint to determine whether subject identity is required. Also returns whether or not email service has been configured, which is required for subject identity verification.
Endpoint:
GET {{host}}/id-verification/config/
Example response:
Changes
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1009