Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Square Erasure APIs added #1398

Merged
merged 4 commits into from
Sep 28, 2022
Merged

Square Erasure APIs added #1398

merged 4 commits into from
Sep 28, 2022

Conversation

Zeeshan-Ethyca
Copy link

@Zeeshan-Ethyca Zeeshan-Ethyca commented Sep 28, 2022 •
edited
Loading

Purpose

  • This PR aims to add a Square connector Customer, Order access endpoints.

Changes

  • Added config for Square Customer erasure Endpoints
  • Added related dataset and configuration
  • Added associated tests and fixtures to validate the above functionality

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add a description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes ethyca/fides#1224

@Zeeshan-Ethyca Zeeshan-Ethyca changed the title 1184 square erasure Square Erasure APIs added Sep 28, 2022
@Zeeshan-Ethyca Zeeshan-Ethyca changed the base branch from main to 1184-square September 28, 2022 01:15
@Zeeshan-Ethyca Zeeshan-Ethyca marked this pull request as ready for review September 28, 2022 01:15
@Zeeshan-Ethyca Zeeshan-Ethyca added the run unsafe ci checks Triggers running of unsafe CI checks label Sep 28, 2022
@Zeeshan-Ethyca
Square erasure apis
d9ba57f 
ref: 11184-square
@Zeeshan-Ethyca
update CHANGELOG.md
117cd9c 
ref: 1184-square-erasure
galvana
galvana reviewed Sep 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Zeeshan-Ethyca
update erasure api tests
aab4982 
ref: 1184-square-erasure
@Zeeshan-Ethyca
update erasure api tests
717cfa0 
ref: 1184-square-erasure
@Zeeshan-Ethyca Zeeshan-Ethyca merged commit 8cd0ca3 into 1184-square Sep 28, 2022
@Zeeshan-Ethyca Zeeshan-Ethyca deleted the 1184-square-erasure branch September 28, 2022 17:51
Zeeshan-Ethyca added a commit that referenced this pull request Sep 28, 2022
@Zeeshan-Ethyca
Square Erasure APIs added (#1398)
b8bac4b 
* Square erasure APIs
ref: 1184-square

# Conflicts:
#	CHANGELOG.md
Zeeshan-Ethyca added a commit that referenced this pull request Oct 3, 2022
@Zeeshan-Ethyca
Square Erasure APIs added (#1398)
525bba6 
* Square erasure APIs
ref: 1184-square

# Conflicts:
#	CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@galvana galvana galvana left review comments

Assignees
No one assigned
Labels
run unsafe ci checks Triggers running of unsafe CI checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Square
2 participants
@Zeeshan-Ethyca @galvana