Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Add deprecation warning #1429

Merged
merged 5 commits into from
Oct 21, 2022
Merged

Add deprecation warning #1429

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f92b63d
Add deprecation warning
TheAndrewJackson Oct 17, 2022
eb024e4
update CHANGELOG.md
TheAndrewJackson Oct 17, 2022
1e1bdad
Update message
TheAndrewJackson Oct 19, 2022
a292f5d
Update Readme
TheAndrewJackson Oct 20, 2022
7b5778c
Merge branch 'main' into 1422_deprecation_warning
TheAndrewJackson Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ The types of changes are:
* `Security` in case of vulnerabilities.

## [Unreleased](https://github.com/ethyca/fidesops/compare/1.8.1...main)
### Added
- Add deprecation warning [#1429](https://github.com/ethyca/fidesops/pull/1429)
### Changed
* Fix redis `db_index` config issue [#1427](https://github.com/ethyca/fidesops/pull/1427)

Expand Down
4 changes: 4 additions & 0 deletions src/fidesops/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,10 @@ def read_ui_files(request: Request) -> FileResponse:

def start_webserver() -> None:
"""Run any pending DB migrations and start the webserver."""
logger.warning(
"Fidesops has been deprecated. The codebase has merged into the Fides repo. Located at "
"https://github.com/ethyca/fides"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current warning message wording is mainly here to serve as a starting point. Do you either @seanpreston or @ThomasLaPiana any specific wording you'd prefer over what is currently there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also link to the docs site? we don't have the official migration guide up yet to link to unfortunately, but I think having links to both would be helpful

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording works for me. Adding something to the README and docs is necessary too. @conceptualshark do you have any opinions here?

)
logger.info("****************fidesops****************")

if logger.getEffectiveLevel() == logging.DEBUG:
Expand Down