Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Fix miradb fixture test warning #436

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Fix miradb fixture test warning #436

merged 1 commit into from
Apr 28, 2022

Conversation

sanders41
Copy link
Contributor

Purpose

Fixes the test warning:

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
    from collections import Generator

Changes

  • Import Generator from typing rather than collections

Checklist

  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #434

@seanpreston
Copy link
Contributor

Good spot, thanks @sanders41

@seanpreston seanpreston merged commit 1bd87d8 into ethyca:main Apr 28, 2022
@sanders41 sanders41 deleted the miradb-fixture-warning branch April 28, 2022 13:04
adamsachs pushed a commit to adamsachs/fidesops_forked_test that referenced this pull request May 17, 2022
sanders41 added a commit that referenced this pull request Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tech debt] Remove testing warning
2 participants