Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

437 user search #444

Merged
merged 2 commits into from
Apr 29, 2022
Merged

437 user search #444

merged 2 commits into from
Apr 29, 2022

Conversation

TheAndrewJackson
Copy link
Contributor

Purpose

Make it possible for the admin ui to search for users by username.

Changes

  • Add username query parameter to the get_users function that allows for filtering by username

Checklist

  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #437

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@adamsachs adamsachs merged commit 86fd4ee into main Apr 29, 2022
@adamsachs adamsachs deleted the 437_user_search branch April 29, 2022 16:05
adamsachs pushed a commit to adamsachs/fidesops_forked_test that referenced this pull request May 17, 2022
* Add user search

* Add user search tests and remove magic numbers
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
* Add user search

* Add user search tests and remove magic numbers
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[User Management] Update GET users API to facilitate user search
2 participants