This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
updates to saas config guide doc to clarify <masked_object_fields> behavior #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conceptualshark
suggested changes
May 5, 2022
| @@ -493,7 +493,7 @@ update: | |||
| direction: from | |||
| ``` | |||
|
|
|||
| Fidesops will replace the `<masked_object_fields>` placeholder with the result of the policy-driven masking service, for example `{'company': None, 'email': None}`. | |||
| Fidesops will replace the `<masked_object_fields>` placeholder with the result of the policy-driven masking service, for example `'company': None, 'email': None`. Note that neither enclosing curly brackets (`{` `}`) nor a trailing comma (`,`) are included as part of the replacement string generated by Fidesops, | |||
There was a problem hiding this comment.
Just a copy edit to replace the comma at the end of this line with a full stop . - otherwise this is good to go!
There was a problem hiding this comment.
whoops, good catch - thanks :)
addressed in e255c91
conceptualshark
approved these changes
May 5, 2022
adamsachs
deleted the
459-masked_object_fields-docs-example-should-include-trailing-comma-or-be-at-end-of-request-body
branch
adamsachs
added a commit
to adamsachs/fidesops_forked_test
that referenced
this pull request
May 17, 2022
…havior (ethyca#464) * updates to saas config guide doc to clarify masked_object_fields behavior * fix typo Co-authored-by: Adam Sachs <[email protected]>
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
…havior (#464) * updates to saas config guide doc to clarify masked_object_fields behavior * fix typo Co-authored-by: Adam Sachs <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ethyca/docs-authors - thought i'd just give a shot at the update for #459 because it was quick and i was already thinking about it, but please feel free to suggest different wording and/or close the PR to make a different change if you think that'd be better
Ticket
Fixes #459