Subject request details page #563
Conversation
| import { useObscuredPII } from '../privacy-requests/helpers'; | ||
|
|
||
| const PII: React.FC<{ data: string }> = ({ data }) => ( | ||
| <>{useObscuredPII(data)}</> |
There was a problem hiding this comment.
I refactored using the useObscuredPII hook into a component because it's starting to become a common pattern.
| @@ -2,13 +2,13 @@ import { Switch } from '@fidesui/react'; | |||
| import React, { ChangeEvent } from 'react'; | |||
| import { useDispatch } from 'react-redux'; | |||
|
|
|||
| import { setRevealPII } from './privacy-requests.slice'; | |||
| import { setRevealPII } from '../privacy-requests/privacy-requests.slice'; | |||
There was a problem hiding this comment.
I moved a few components into the common directory because they're being used on multiple pages.
| const actions = Array.from( | ||
| new Set( | ||
| rules | ||
| .filter((d) => Object.values(ActionType).includes(d.action_type)) |
There was a problem hiding this comment.
We're going to display the request type using the action type on rules now. This component handles de-duping the rules just in case there are multiple rules that are the same type.
| status, | ||
| id, | ||
| from, | ||
| to, | ||
| page, | ||
| size, | ||
| }: Partial<PrivacyRequestParams>) => { | ||
| verbose, | ||
| }: Partial<PrivacyRequestParams>): any { |
There was a problem hiding this comment.
The Typescript compiler was struggling to resolve the return type on this function so I updated it to this to make the linter happy.
| @@ -35,13 +36,14 @@ export const mapFiltersToSearchParams = ({ | |||
| return { | |||
| include_identities: 'true', | |||
| ...(status ? { status } : {}), | |||
| ...(id ? { id } : {}), | |||
| ...(id ? { request_id: id } : {}), | |||
There was a problem hiding this comment.
The backend looks for request_id when filtering
| subjectRequest: PrivacyRequest; | ||
| }; | ||
|
|
||
| const EventsAndLogs = ({ subjectRequest }: EventsAndLogsProps) => { |
There was a problem hiding this comment.
This component is mostly finished. It's waiting on some mockups to be finished. I talked with @seanpreston and we decided to leave it in the repo without being used because the work was already done here.
clients/admin-ui/src/features/subject-request/ActivityTimeline.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This looks great to me! Just a few small notes, and then I think we'll be good to merge! I think this should be merged before #577, since it'll be easier for me to rebase that work.
eastandwestwind
dismissed
elliotbonneville’s stale review
requested changes have been addressed
* Get initial page setup and fix some eslints * Finish majority of UI styling * Finished clipboard button * refactor page component * Add prettier to project * Format project with prettier * Add format command * rename files * Add icons and lines * WIP event details table * Run prettier on codbase 😭 * Add finishing touches for latest mock ups * Fix frontend lint error * Update Request type to use rule action types * Fix typing issue * Fix lint issues * Fix last lint issue 🤞 * Update changelog * Run prettier formatter * Remove unused clipboard icon * Remove comment * Remove ts-ignore * Fix changelog file
Purpose
Add a dedicated page to look at details for subject requests.
Changes
Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #493, #494