This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Refactor user management UI code #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import { EyeIcon } from "../../common/Icon"; | ||
|
|
||
| interface InputProps { |
There was a problem hiding this comment.
Is our standard to use interface or type?
There was a problem hiding this comment.
oh I don't know! I use interface out of habit, but it appears they're pretty interchangeable? happy to go with whatever people prefer
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Refactor pages to use the same Layout * Add UserForm.tsx * Add Yup validation schema * Integrate refactored form to New route * Styling * WIP refactor EditUserForm * Fix EditUserForm typescript errors * Refactor handleSubmit * Small fixes to EditUserForm * Make call to get scopes earlier so form will be populated on first render * Update changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There was a lot of duplicate code between
EditUserForm.tsxandNewUserForm.tsx. This PR separates their commonalities intoUserForm.tsx.Changes
EditUserForm.tsxandNewUserForm.tsxto both call a newUserForm.tsxCustomTextInputlike we have in fidesctl. Eventually, I think this form input should be pulled into fidesui, but for now, it's copied over and tweaked. This component also comes with an Eye icon that lets you reveal the password.EditUserForm.tsx(there was a// @ts-nocheckat the top which was hiding a lot of errors)user-management-slice.tsxChecklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #812
Flow for adding/editing a user
Screen.Recording.2022-07-08.at.2.12.34.PM.mov
Form validation via Yup
Screen.Recording.2022-07-08.at.2.15.17.PM.mov
When editing your own user, you'll have the option to change your password
