Reduce binary size #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/rust/src/lib.rs
Outdated
| @@ -73,7 +76,7 @@ impl UnicodePosition { | |||
|
|
|||
| #[derive(Clone)] | |||
| pub struct SgRoot { | |||
| inner: AstGrep<StrDoc<SupportLang>>, | |||
| inner: AstGrep<StrDoc<tree_sitter_facade_sg::Language>>, | |||
There was a problem hiding this comment.
IMHO it should be StrDoc<R> here. StrDoc accepts a type parameter satisfying ast_grep_core::Language. The R language implemented here should be the one to use.
| @@ -82,9 +85,9 @@ pub struct SgRoot { | |||
| impl SgRoot { | |||
| fn new(src: &str) -> Self { | |||
| let position = UnicodePosition::new(src); | |||
| let lang = SupportLang::R; | |||
There was a problem hiding this comment.
ditto, R.ast_grep(src) should be sufficient here.
src/rust/src/language.rs
Outdated
| /// normalize pattern code before matching | ||
| /// e.g. remove expression_statement, or prefer parsing {} to object over block | ||
| fn pre_process_pattern<'q>(&self, query: &'q str) -> Cow<'q, str> { | ||
| Cow::Borrowed(query) |
There was a problem hiding this comment.
You may also need to pre_process_pattern if $ is not a valid identifier in R.
src/rust/src/language.rs
Outdated
| /// * which character is used for meta variable. | ||
| /// * if we need to use other char in meta var for parser at runtime | ||
| /// * pre process the Pattern code. | ||
| pub trait Language: Clone { |
There was a problem hiding this comment.
Why not use ast_grep_core::Language here?
|
I think my last commit should work, thanks so much for your help @HerringtonDarkholme, I really appreciate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.