Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete FutureMixin #58

Merged
merged 4 commits into from
Aug 24, 2023
Merged

delete FutureMixin #58

merged 4 commits into from
Aug 24, 2023

Conversation

egoriyaa
Copy link
Collaborator

@egoriyaa egoriyaa commented Aug 23, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #33

@github-actions
Copy link

github-actions bot commented Aug 23, 2023

🚀 Deployed on https://deploy-preview-58--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 23, 2023 07:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 23, 2023 10:09 Inactive
Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Update the Changelog
  2. Creating the "Pull request"
  • Don't forget to assign yourself to it(and to the issue too)
  • Also you need to assign the reviewer
  • In "Closes" block you need to add link to the corresponding issue, which will be automatically closed when PR is merged

@egoriyaa egoriyaa self-assigned this Aug 24, 2023
@github-actions github-actions bot temporarily deployed to pull request August 24, 2023 08:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 24, 2023 09:22 Inactive
Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alex-hse-repository alex-hse-repository merged commit 1d20ffc into master Aug 24, 2023
12 checks passed
@egoriyaa egoriyaa deleted the issue-33 branch August 29, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove FutureMixin class
2 participants