Clean up javascript libraryDependencies #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
changed the title
mdedetrich
force-pushed
the
cleanUpBuild
branch
from
3b460a9
to
ebd7d39
Compare
mdedetrich
force-pushed
the
cleanUpBuild
branch
from
ebd7d39
to
1ea9ae6
Compare
mdedetrich
changed the title
|
@etorreborre This PR is now complete The idea is that instead of mixing js dependencies and JVM dependencies, JVM only projects (designated as You run into a lot of weird issues if you mix Scala.js maven jars and Java maven jars, this PR attempts to resolve this. After this is merged, another PR will be done to migrate to https://github.com/portable-scala/sbt-crossproject which we need for scala-native. This PR will likely do a lot of cleaning up so the build is nicer and more maintainable, and adding scala-native support (when all of the dependencies are built for scala-native) should be quite trivial. |
|
Thanks Matthew. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to clean up the specs2 build a bit. A lot more can be done, but I think this is better done coinciding with #591 (which I will plan to do a bit later)