Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up javascript libraryDependencies #620

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

mdedetrich
Copy link
Contributor

This PR attempts to clean up the specs2 build a bit. A lot more can be done, but I think this is better done coinciding with #591 (which I will plan to do a bit later)

@mdedetrich mdedetrich changed the title Clean up javascript libraryDependencies [WIP] Clean up javascript libraryDependencies Dec 13, 2017
@mdedetrich mdedetrich changed the title [WIP] Clean up javascript libraryDependencies Clean up javascript libraryDependencies Dec 13, 2017
@mdedetrich
Copy link
Contributor Author

mdedetrich commented Dec 13, 2017

@etorreborre This PR is now complete

The idea is that instead of mixing js dependencies and JVM dependencies, JVM only projects (designated as .jvm) only depend on JVM sources and the same applies for Javascript.

You run into a lot of weird issues if you mix Scala.js maven jars and Java maven jars, this PR attempts to resolve this.

After this is merged, another PR will be done to migrate to https://github.com/portable-scala/sbt-crossproject which we need for scala-native. This PR will likely do a lot of cleaning up so the build is nicer and more maintainable, and adding scala-native support (when all of the dependencies are built for scala-native) should be quite trivial.

@etorreborre
Copy link
Owner

Thanks Matthew.

@etorreborre etorreborre merged commit 90cb6ae into etorreborre:master Dec 13, 2017
@mdedetrich mdedetrich deleted the cleanUpBuild branch December 13, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants