Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apollo-boost] Fix Typescript >= 3.6 #1

Closed
wants to merge 2 commits into from
Closed

[apollo-boost] Fix Typescript >= 3.6 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dd62f9
Update apollo-boost types for TS >= 3.6
Nov 12, 2019
cd7d0c5
Update fetch type for Typescript >= 3.6
Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/get-started.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ Here are the options you can pass to the `ApolloClient` exported from `apollo-bo
| `cacheRedirects` | Object | A map of functions to redirect a query to another entry in the cache before a request takes place. This is useful if you have a list of items and want to use the data from the list query on a detail page where you're querying an individual item. More on that <a href="/features/performance">here</a>. |
| `credentials` | string | Is set to `same-origin` by default. This option can be used to indicate whether the user agent should send cookies with requests. See <a href="https://developer.mozilla.org/en-US/docs/Web/API/Request/credentials">Request.credentials</a> for more details. |
| `headers` | Object | Header key/value pairs to pass along with the request. |
| `fetch` | GlobalFetch['fetch'] | A <a href="https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API">`fetch`</a> compatible API for making a request. |
| `fetch` | WindowOrWorkerGlobalScope['fetch'] | A <a href="https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API">`fetch`</a> compatible API for making a request. |
| `cache` | ApolloCache | A custom instance of `ApolloCache` to be used. The default value is `InMemoryCache` from `apollo-cache-inmemory`. This option is quite useful for using a custom cache with `apollo-cache-persist`. |

## Next steps
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-boost/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export interface PresetConfig {
uri?: string | UriFunction;
credentials?: string;
headers?: any;
fetch?: GlobalFetch['fetch'];
fetch?: WindowOrWorkerGlobalScope['fetch'];
fetchOptions?: HttpLink.Options;
clientState?: ClientStateConfig;
onError?: ErrorLink.ErrorHandler;
Expand Down