I rewrote the unpitch-rater entirely this time #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notable changes outside SpeedChange good: - RageSound.cpp: Moving PostBuffering. This lets you change volume immediately. Before nothing buffered long enough for this to happen, but at rates of 0.05 the amount of buffering by SpeedChange_Good is very long, so if you have it really loud and try to reduce the volume, nothing happens. Very bad - GameSoundManager.cpp: Initialising music with the current rate pre-applied. Without this the first few reads of a file often have no rate applied which is audible in the music wheel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sounds good now. The way I did it doesn't work well for downrates, but it turns out to not work well in a different way than the old SpeedChange method, so in that case you can use them both and get alright results in the 0.8-0.95 range? Really nice how that turned out. Anyway what I implemented here is dirt simple, and never skips or moves beats on uprates. Sometimes 32nd rhythms get mangled up at like 1.8 but that's about it I think.
Like half the code is just for an easter egg when you go down to 0.05, everything in the range 0.5-3.0 is time domain only so should still run on a toaster