Allow stopping reading at the end of the circular buffer #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euank
force-pushed
the
pr/allow-nofollow
branch
3 times, most recently
from
d4cbacb
to
4d73d57
Compare
This requires putting the fd into nonblocking mode, but keeping it outside of the epoll runtime stuff. As such, it's implemented as a separate codepath to contain the hackiness. This is a breaking change, so v3
euank
force-pushed
the
pr/allow-nofollow
branch
from
4d73d57
to
b61bd93
Compare
The parse api should have had the caller give a channel from the beginning I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires putting the fd into nonblocking mode, but keeping it outside of the epoll runtime stuff.
As such, it's implemented as a separate codepath to contain the hackiness.
This is a breaking change, so v3
I also dropped some tests that are tricky to implement since mocking /dev/kmsg semantics in go is a bit annoying.
I also updated
Parseto take a channel as an input and not spin off its own goroutine. This gives a better api, and most notably better error handling.