Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for latest Nim #49

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Fixes for latest Nim #49

merged 2 commits into from
Sep 21, 2023

Conversation

RSDuck
Copy link
Contributor

@RSDuck RSDuck commented Sep 21, 2023

  • useWinUnicode was removed a while ago, now typically only the Unicode APIs are used (see remove decades-deprecated Win32 API *A function support nim-lang/Nim#21315).
  • Deriving exceptions directly off Exception generated some warnings saying that they should be derived of a more concrete exception type.
  • Putting together a set of int consts/literals would previously create an int16 set, now it's an error. So I replaced the set by an array.
  • Getting the pointer of the wide string by casting it to pointer seems to not work anymore? It works this way (which I think should also be more stable).

Only tested on Windows, there might still remain issues on other platforms.

@euantorano
Copy link
Owner

Thanks so much for the contribution.

A quick glance through looks good, but I don't currently have my USB to RS232 adapters to hand to actually test with. I'm going to merge this, but not tag a new release just yet until I've had a chance to test it myself.

@euantorano euantorano merged commit e794dd3 into euantorano:master Sep 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants