This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
Added testcase for Instance Profile Information Presented in Instance Metadata Service #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.py to include instance profile arn/name every where instances were being launched
…could be used when running instances; updated assertGreaterEqual and assertLessEqual to assertTrue
…latest/meta-data/iam/info/last-updated-date, temporary credentials variables LastUpdated and Expiration.
| @@ -2404,6 +2406,8 @@ def run_instance(self, | |||
| :param max: Maxiumum instances to launch, default 1 | |||
| :param user_data: User-data string to pass to instance | |||
| :param private_addressing: Runs an instance with only private IP address | |||
| :param instance_profile_name: name of the IAM (Euare) profile to associate with the instances | |||
| :param instance_profile_arn: ARN of the IAM (Euare) instance profile to associate with the instances | |||
There was a problem hiding this comment.
Can we just add 1 param which is the name, and then translate to the arn if necessary?
|
Hey @hspencer77, good work here. We should definitely have this test in and start running in the CI. Would you mind sending a PR to the master branch by changing the class name to something like "InstanceProfileTests"? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a testcase that allows Instance Profile Name/ARN to be passed when running instances. This case was developed to test the metadata service (http://169.254.169.254/latest/metadata/) regarding instance profile of an instance for consistency.
The following meta-data attributes are tested:
If any of these tests fail, the test case will error out; logging the results.
Examples of using either instance profile name or instance profile ARN in testcase are below:
String length tests are based on the following AWS specs: