Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Make debugger widgets more compact #94

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jackTabsCode
Copy link
Collaborator

This is a heavily opinionated PR. I believe that Plasma's widgets and by extension, Matter's debugger widgets are a little too big. This PR makes them a bit more compact. It's not completely finished yet.

See evaera/plasma#14, a related PR.

@jackTabsCode
Copy link
Collaborator Author

Before:
image

After:
image

@Ukendio
Copy link
Contributor

Ukendio commented Dec 23, 2023

I think this all looks better, but I would like to see more structural changes and that is more indicative of the UI needing a redesign in my opinion. The feeling as to why I feel like this is more bloated as opposed to something like imGUIs presets for UI is the size of padding, the style and such.

I might not have everyones vote of confidence in having an eye for design but I think Flecs have a great dashboard that feels compact and uniform
image

@jackTabsCode
Copy link
Collaborator Author

Sure, I agree with you, but the PR is intended to make the widgets a little more usable. A full redesign is out of scope for this PR and is not something I have time for.

Ideally the APIs that the debugger can be made public at some point so that we can ship our own if we disagree.

@jackTabsCode
Copy link
Collaborator Author

Should also be noted that the reason this is a draft is because it's not finished. I haven't gotten to all of the widgets in Plasma yet

@Ukendio
Copy link
Contributor

Ukendio commented Dec 23, 2023

A full redesign is out of scope for this PR and is not something I have time for.

The way I see it is that if we plan to redesign it, all of this effort may go to waste. It is your decision whether you want to continue this though.

@jackTabsCode
Copy link
Collaborator Author

I am not aware of a project to fully redesign the debugger. What was discussed was to simply make it separable from Matter.

Regardless, these changes took less than 10 minutes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants