Fix #39

evaera · Aug 24, 2020 · e7a01c7 · e7a01c7
1 parent a425606
commit e7a01c7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 ### Fixed
 - Make `Promise.is` work with promises from old versions of the library (#41)
 - Make `Promise.delay` properly break out of the current loop (#40)
+- Allow upvalues captured by queued callbacks to be garbage collected when the Promise resolves by deleting the queues when the Promise settles (#39)
 
 ## [3.0.0] - 2020-08-17
 ### Changed

diff --git a/lib/init.lua b/lib/init.lua
@@ -1292,6 +1292,10 @@ function Promise.prototype:_finalize()
 		coroutine.wrap(callback)(self._status)
 	end
 
+	self._queuedFinally = nil
+	self._queuedReject = nil
+	self._queuedResolve = nil
+
 	-- Clear references to other Promises to allow gc
 	if not Promise.TEST then
 		self._parent = nil