Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sirupsen to Sirupsen #53

Closed
wants to merge 1 commit into from
Closed

Conversation

sysradium
Copy link

@sysradium sysradium commented Jun 19, 2017

There is an issue with this lib when is used together with the glide vendoring tool.

If I add logrus_sentry as a dependency to the glide.yml I will end up with this errors during glide install:

[INFO]	--> Fetching updates for github.com/sirupsen/logrus.
[ERROR]	Error looking for github.com/sirupsen/logrus: The Remote does not match the VCS endpoint

This is because you specify github.com/sirupsen/logrus as a dependency instead of github.com/Sirupsen/logrus. It breaks only on case-sensitive FS (for example OSX).

Refence: Masterminds/glide#781

@coveralls
Copy link

coveralls commented Jun 19, 2017

Coverage Status

Coverage remained the same at 83.102% when pulling 1edc001 on sysradium:master into 9f8f2d0 on evalphobia:master.

@arp242
Copy link
Contributor

arp242 commented Jun 30, 2017

sirupsen is the name that should be used; this got changed in #48. If there are projects that use the old Sirupsen name then those should be updated, too.

You can probably get away by manually renaming the repo in the glide files?

The entire Sirupsen -> sirupsen is annoying, but keeping the old name isn't really going to work in the long term. Loads of projects are renaming it now, see the references in sirupsen/logrus#384

@sysradium
Copy link
Author

Ok, I see. Thanks for the explanation. This sucks a lot :(

@arp242
Copy link
Contributor

arp242 commented Jul 1, 2017

BTW I noticed just now that in the README it mentions:

Seeing weird case-sensitive problems? It's in the past been possible to
import Logrus as both upper- and lower-case. Due to the Go package environment,
this caused issues in the community and we needed a standard. Some environments
experienced problems with the upper-case variant, so the lower-case was decided.
Everything using logrus will need to use the lower-case:
github.com/sirupsen/logrus. Any package that isn't, should be changed.

I am terribly sorry for this inconvenience. Logrus strives hard for backwards
compatibility, and the author failed to realize the cascading consequences of
such a name-change. To fix Glide, see these
comments
.

So maybe try that to fix your problem?

@sysradium sysradium closed this Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants